Fix redirection to 'next' url raises an unsafe error

[sjyangkevin]

Close: #55473

why

The is_safe_url method will return False when the target_url is encoded and it is the same as either base_url or request.base_url. Therefore, we will unquote it before joining with base.

#55143 (comment)
#55473

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

[pierrejeambrun]

I think we should always unquote.

can you add a test where the target url is “relative” to the base url (I.e nested down the path).

I think with the current code that wouldn’t work, but it should.

For instance:
"https%3A%2F%2Frequesting_server_base_url.com%2Fprefix2%2Fsub_path”

[sjyangkevin]

Thanks for the feedback. Will make the change and add the test case

[jason810496]

Thanks for the fix.

[sjyangkevin]

Thanks @pierrejeambrun , @jason810496

I think we should always unquote.
can you add a test where the target url is “relative” to the base url (I.e nested down the path).
I think with the current code that wouldn’t work, but it should.
For instance: "https%3A%2F%2Frequesting_server_base_url.com%2Fprefix2%2Fsub_path”

Yes. In the case of target url is "relative" to the base url, the additional check there will fail to unquote the target url. Thanks for pointing this out.

[jason810496]

Yes. In the case of target url is "relative" to the base url, the additional check there will fail to unquote the target url. Thanks for pointing this out.

Thanks for the update! Having unquote in the loop make more sense to me.

[pierrejeambrun]

Nice thanks

[gyanprakash48]

@sjyangkevin i am still facing this error , i am on helm chart 1.18.0 and and then using image defaultAirflowTag: "3.1.5" . I set AIRFLOW__WEBSERVER__BASE_URL as well in apiserver , but still error persist. {"detail":"Invalid or unsafe next URL"}. i can see next path is url encoded . any help what i need to do ? (if i manually remove url encoding in browser then it works, that specific navigation)

[jason810496]

@sjyangkevin i am still facing this error , i am on helm chart 1.18.0 and and then using image defaultAirflowTag: "3.1.5" . I set AIRFLOW__WEBSERVER__BASE_URL as well in apiserver , but still error persist. {"detail":"Invalid or unsafe next URL"}. i can see next path is url encoded . any help what i need to do ? (if i manually remove url encoding in browser then it works, that specific navigation)

How about using AIRFLOW__API__BASE_URL instead of AIRFLOW__WEBSERVER__BASE_URL env?
It seems we didn't handle [webserver/base_url] to [api/base_url] config properly:

https://github.com/apache/airflow/blob/main/shared/configuration/src/airflow_shared/configuration/parser.py#L130-L160

[sjyangkevin]

Thanks @jason810496 . I think it could be the issue. @gyanprakash48 could you try out the setting @jason810496 suggest?

[gyanprakash48]

Thanks! , yes that solved 👍