Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Sep 17, 2025

Why

"error_type" can't == "timeout". It should be event["error_type"] == "timeout" instead

What

Check the content inside the dict instead of the key itself


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Lee-W Lee-W changed the title fix(hitl): fix HITL timeout error handling fix(HITL): timeout error handling Sep 17, 2025
@Lee-W Lee-W requested a review from jscheffl September 17, 2025 09:27
@Lee-W Lee-W added this to the Airflow 3.1.0 milestone Sep 17, 2025
@Lee-W Lee-W force-pushed the fix-hitl-timeout-errror branch from 5471bc4 to 2537788 Compare September 17, 2025 10:01
@Lee-W Lee-W mentioned this pull request Sep 17, 2025
@Lee-W Lee-W requested a review from jason810496 September 17, 2025 13:53
@Lee-W Lee-W self-assigned this Sep 17, 2025
@Lee-W Lee-W merged commit 3ee8cd4 into apache:main Sep 17, 2025
109 checks passed
@Lee-W Lee-W deleted the fix-hitl-timeout-errror branch September 17, 2025 22:51
kaxil pushed a commit that referenced this pull request Sep 18, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants