-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[v2-11-test] Prevent scheduler to crash due to RecursionError when making a SQL query #55778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2-11-test
Are you sure you want to change the base?
[v2-11-test] Prevent scheduler to crash due to RecursionError when making a SQL query #55778
Conversation
86ec93e to
2a4f3ba
Compare
2a4f3ba to
99d1123
Compare
|
Generally you should target main with any bug fixes, unless there is a specific reason why it only applies to the 2.x branch. |
@ashb as I mentioned in PR's description this problem doesn't exist in AF3(
|
|
Whoops sorry. That'll teach me for doing PR reviews before the coffee has kicked in |
99d1123 to
3250c43
Compare
|
Hello @potiuk, |
|
This is going to be fixed once I merge finally #51681 which I will be working on in the next days much more, |
|
3.1.3 out -> so we can focus now on 2.11.1 :) |
|
Hi @potiuk ! thank you for checking this one :) |
|
IT's not passed. I am working on 2.11.1 soon, and I will decide then what to merge @VladaZakharova We are committed to releasing criticial and security fixes for Airflow 2 until May 2026 |
In this PR I have added a
try-exceptblock for preventing the scheduler from crashing due toRecursionErrorwhen making a SQL query. This error happens when a session tries to commit a transaction withnon-json-serializbleparameters(task-instance, dag-runs, context, etc.) here.The DAG which can reproduce this error:
This problem doesn't exist for AF3. Because for AF3 the code raise exception and failed immediately in place where discover the
non-json-serializabledata. In the AF2 the code shows the warning that usingnon-json-serializableparameters will be deprecated in AF3. It does not prevent airflow from crashing later with more dramatic consequences.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.