Skip to content

Hide "deferred chip" on Dashboard unless pool is set to count deferred #55857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KatalKavya96 wants to merge 2 commits into from
Closed

Hide "deferred chip" on Dashboard unless pool is set to count deferred #55857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f86825
UI(Pools, Dashboard): Hide deferred chip unless pool counts deferred …
KatalKavya96 Sep 18, 2025
bb793ec
Reduced comments
KatalKavya96 Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions airflow-core/src/airflow/ui/src/components/PoolBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,22 @@ export const PoolBar = ({
return undefined;
}

// is configured NOT to include deferred in occupied slots, hide this chip.
// (We only have the flag on real pools; aggregated "Slots" objects don't carry it)
const isDeferredKey = key === "deferred_slots";

if (
isDeferredKey &&
"include_deferred" in pool && // type guard: only PoolResponse has this
!pool.include_deferred
) {
return undefined;
}

const slotType = key.replace("_slots", "");
const poolCount = poolsWithSlotType ? poolsWithSlotType[key] : 0;
const tooltipContent = `${translate(`pools.${slotType}`)}: ${slotValue} (${poolCount} ${translate("pools.pools", { count: poolCount })})`;

const poolContent = (
<Tooltip content={tooltipContent} key={key}>
<Flex
Expand Down
6 changes: 6 additions & 0 deletions airflow-core/src/airflow/ui/src/pages/Dashboard/PoolSummary/PoolSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export const PoolSummary = () => {

const pools = data?.pools;
const totalSlots = pools?.reduce((sum, pool) => sum + pool.slots, 0) ?? 0;

const aggregatePool: Slots = {
deferred_slots: 0,
open_slots: 0,
Expand All @@ -58,6 +59,11 @@ export const PoolSummary = () => {
slotKeys.forEach((slotKey) => {
const slotValue = pool[slotKey];

// NEW: only include deferred slots from pools that count deferred
if (slotKey === "deferred_slots" && !pool.include_deferred) {
return;
}

if (slotValue > 0) {
aggregatePool[slotKey] += slotValue;
poolsWithSlotType[slotKey] += 1;
Expand Down