Skip to content

Conversation

@karunpoudel
Copy link
Contributor

@karunpoudel karunpoudel commented Sep 19, 2025

pre-requisite: #52182

Add functionality to authenticate to Snowflake using Azure Entra ID authentication.

Example connection extra fields:

{
    "database": "db",
    "account": "airflow",
    "region": "af_region",
    "authenticator": "oauth",
    "azure_conn_id": "azure_default_conn"
}

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@karunpoudel
Copy link
Contributor Author

this pr is ready for review and merge

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed - LGTM overall, but needs a last polish before merging :)

@shahar1 shahar1 self-requested a review October 4, 2025 12:39
@shahar1
Copy link
Contributor

shahar1 commented Oct 17, 2025

Almost there, one compat test seems to be failing

@karunpoudel-chr
Copy link
Contributor

Almost there, one compat test seems to be failing

Failure seems to be on unrelated change from main. All tests had passed once, but keeps failing on different tests every time I update from main.

@karunpoudel-chr
Copy link
Contributor

Almost there, one compat test seems to be failing

all checks have passed now

@shahar1 shahar1 merged commit d8b3300 into apache:main Oct 17, 2025
92 checks passed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
Co-authored-by: Karun Poudel <64540927+karunpoudel-chr@users.noreply.github.com>
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
Co-authored-by: Karun Poudel <64540927+karunpoudel-chr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants