Add GCS Dag bundle (unversioned) #55919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:google
shahar1
force-pushed
the
gcs-dags-bundle
branch
2 times, most recently
from
4445a72 to
66bb10a
Compare
jason810496
reviewed
Sep 22, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice! Thanks for the PR and LGTM overall !
providers/google/src/airflow/providers/google/cloud/bundles/gcs.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/bundles/gcs.py
Outdated
Show resolved
Hide resolved
shahar1
force-pushed
the
gcs-dags-bundle
branch
2 times, most recently
from
46e7158 to
aa8f8ae
Compare
Contributor
Author
|
Failing static checks are unrelated (go files) |
shahar1
force-pushed
the
gcs-dags-bundle
branch
from
aa8f8ae to
72ae4cc
Compare
ephraimbuddy
reviewed
Oct 9, 2025
providers/google/src/airflow/providers/google/cloud/bundles/gcs.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/bundles/gcs.py
Outdated
Show resolved
Hide resolved
ephraimbuddy
approved these changes
Oct 9, 2025
shahar1
force-pushed
the
gcs-dags-bundle
branch
from
72ae4cc to
f2680eb
Compare
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
69 tasks
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces: #55909
Following the recent thread in the dev. list for creating a GCS Dag Bundle, I've adapted S3 implementation to fit GCS. Currently the implementation is unversioned.
In the future, it might be a good idea to extract the shared logic into the common provider for DRY purposes, but for now I wanted to focus on getting this implementation in place.
Future work could include handling versioning (manifest file?), parallelization, etc.
cc: @kosteev
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.