Skip to content

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Sep 21, 2025

Why

https://apache-airflow.slack.com/archives/C015SLQF059/p1758442955070459


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be because of fastapi version bump?

@amoghrajesh
Copy link
Contributor

@Lee-W we specify fastapi dependency this way:

"fastapi[standard-no-fastapi-cloud-cli]>=0.116.0"

So this would start to fail even if a version lower than 0.117.1 would be installed. I think the right fix would be to bump min fastapi version along with these changes

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Thanks for the fix!

Note as of static issues with Edge assets, was adding a commit on top in PR #55931

@Lee-W
Copy link
Member Author

Lee-W commented Sep 21, 2025

Yep, I just was wondering why the CI would pass at the first place. Thanks all for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:providers provider:edge Edge Executor / Worker (AIP-69)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants