Add number of queries guard in public xcom entries list endpoints #55936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guan404ming
force-pushed
the
fix-lazy-loading
branch
from
265d7f3 to
69c46e7
Compare
guan404ming
force-pushed
the
fix-lazy-loading
branch
2 times, most recently
from
3c5d0fd to
cf5aa7d
Compare
guan404ming
requested review from
XD-DENG,
ashb,
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
Member
There was a problem hiding this comment.
I am working on this for all 'list' endpoint, across all entities and public/ui apis.
I am first taking care of only list endpoint because those are the most critical for N+1 query problem. Then we can do the same for other endpoints.
You can probably rebase on the PR above, keep the xcom part and the 'noload'. Rename the PR description and add the assert_queries_count in tests. Too
airflow-core/src/airflow/api_fastapi/core_api/routes/public/event_logs.py
Outdated
Show resolved
Hide resolved
guan404ming
force-pushed
the
fix-lazy-loading
branch
from
cf5aa7d to
74f1f50
Compare
Member
Author
Sure, I've modified this PR to ensure there is no N+1 query issue for list |
guan404ming
changed the title
guan404ming
force-pushed
the
fix-lazy-loading
branch
from
74f1f50 to
314cd84
Compare
pierrejeambrun
added
the
backport-to-v3-1-test
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 30, 2025
…ndpoints (apache#55936) (cherry picked from commit fc72417) Co-authored-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add number of db queries guard in list endpoint, preventing further N+1 queries problem
N+1 queries problem detected and solved.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.