fix(api_fastapi): adjust model validator signature of TriggerDAGRunPo… #56026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dada-engineer
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
pierrejeambrun
approved these changes
Sep 24, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Thanks for catching this.
LGTM.
CI need fixing.
Member
That looks unrelated, let me rebase your branch and start again the CI |
pierrejeambrun
force-pushed
the
fix/56025-dag-run-post-body-validation
branch
from
8126d10 to
3333306
Compare
jason810496
approved these changes
Sep 25, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Just rebased again to fix the CI error.
jason810496
force-pushed
the
fix/56025-dag-run-post-body-validation
branch
from
3333306 to
16684f5
Compare
bugraoz93
approved these changes
Sep 26, 2025
Contributor
|
Thanks for the PR! |
pierrejeambrun
approved these changes
Sep 30, 2025
pierrejeambrun
added
the
backport-to-v3-1-test
Backport successfully created: v3-1-test
|
2 tasks
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
pierrejeambrun
pushed a commit
that referenced
this pull request
Oct 1, 2025
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
…stBody (apache#56025) (apache#56026) Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
Contributor
|
Is this coming into the 3.0.x line? because without this then manual DAG triggering in 3.0.x is effectively broken correct? |
Contributor
Author
|
@fredthomsen IMO it is broken yes, and I think it will be part of 3.1.1 |
Member
|
Yes. We generally practically never fix things in past branch if new release is already out. You should simply upgrade to latest version of airflow released when it is released to fix any bugs. That's our policy. The only exception is 2.11 that will get security and critical fixes unti April 2026 (also our policy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #56025
The model validator signature of TriggerDAGRunPostBody was defined to match a before validator, it is using a after validator though. This validator type should expect the instaniated model itself not the class and a values dict.