Use separate method to decide if task is to be scheduled #56039
Merged
+142
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Sep 24, 2025
ashb
changed the title
kacpermuda
force-pushed
the
nit-is-schedulable-task
branch
from
7690a51 to
a9d76ea
Compare
Contributor
Author
ashb
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check whether or not to schedule a task is now done within
schedule_tismethod, I think it would be beneficial to extract that logic into a separate public method.If task is not being scheduled, the listeners are not called for it - and some listeners would like to know that ahead of time, which would be easier if there was a separate method for that decision. Right now the OL listener was re-creating the logic from the Airflow core, but it became complex and hard to keep up with. I'll have another PR for the OpenLineage provider to check for existence of this new
is_schedulable_taskmethod, and call it instead.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.