-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Allow a list of SQL statements in GenericTransfer #56041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eladkal
merged 25 commits into
apache:main
from
dabla:feature/allow-multiple-sql-statements-in-generic-transfer
Oct 29, 2025
Merged
Allow a list of SQL statements in GenericTransfer #56041
eladkal
merged 25 commits into
apache:main
from
dabla:feature/allow-multiple-sql-statements-in-generic-transfer
Oct 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t like the SQLExecuteQueryOperator to avoid the need to use partial/expand which is way more expensive than looping over the SQL-statements within the operator
potiuk
reviewed
Oct 13, 2025
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Oct 28, 2025
providers/common/sql/src/airflow/providers/common/sql/operators/generic_transfer.py
Show resolved
Hide resolved
uranusjr
reviewed
Oct 28, 2025
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py
Outdated
Show resolved
Hide resolved
…s/generic_transfer.py Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
…ments are defined
…icTransfer" This reverts commit 881f447.
uranusjr
approved these changes
Oct 29, 2025
eladkal
approved these changes
Oct 29, 2025
Lzzz666
pushed a commit
to Lzzz666/airflow
that referenced
this pull request
Oct 30, 2025
* refactor: Allow a list of SQL to be passed to the GenericTransfer just like the SQLExecuteQueryOperator to avoid the need to use partial/expand which is way more expensive than looping over the SQL-statements within the operator * refactor: Reformatted execute method in GenericTransfer * Update providers/common/sql/src/airflow/providers/common/sql/operators/generic_transfer.py Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> * refactor: Reverted list to str for sql parameter in test GenericTransfer * refactor: Move check of sql parameter in constructor of GenericTransfer * refactor: Added unit test for GenericTransfer when multiple SQL statements are defined * Revert "refactor: Move check of sql parameter in constructor of GenericTransfer" This reverts commit 881f447. --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a list of SQL statements to be passed to the GenericTransfer just like the SQLExecuteQueryOperator to avoid the need to use partial/expand which is way more expensive than looping over the SQL-statements within the operator.
The use-case is inspired from this medium article where there it was still using partial/expand.
An example:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.