Skip to content

Conversation

@sealmove
Copy link
Contributor

closes: #56029


This is a simple fix that I had to do for my deployment.
I am not sure what to comment since the change is very small and self-explanatory.

With this change Airflow queries the Docker Swarm cluster properly, and doesn't rely on the container to exist locally (which is not always true for a cluster).

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 24, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal requested a review from jason810496 September 24, 2025 17:34
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR!

@jason810496 jason810496 merged commit 8002457 into apache:main Sep 27, 2025
76 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 27, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
…er() (apache#56043)

* use inspect_service() instead of inspect_container()

* fix tests

* fix formatting

---------

Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DockerSwarmOperator uses inspect_container()

2 participants