-
Notifications
You must be signed in to change notification settings - Fork 16.3k
DockerSwarmOperator: Use inspect_service() instead of inspect_container() #56043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the PR!
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
…er() (apache#56043) * use inspect_service() instead of inspect_container() * fix tests * fix formatting --------- Co-authored-by: stefanos-mandalas <stefanos.mandalas@nowsystems.eu>
closes: #56029
This is a simple fix that I had to do for my deployment.
I am not sure what to comment since the change is very small and self-explanatory.
With this change Airflow queries the Docker Swarm cluster properly, and doesn't rely on the container to exist locally (which is not always true for a cluster).