Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,9 @@ def pod_manager(self) -> PodManager:

def get_body(self):
self.body: dict = SparkJobSpec(**self.template_body["spark"])
self.body.metadata = {"name": self.name, "namespace": self.namespace}
if not hasattr(self.body, "metadata") or not isinstance(self.body.metadata, dict):
self.body.metadata = {}
self.body.metadata.update({"name": self.name, "namespace": self.namespace})
if self.template_body.get("kubernetes"):
k8s_spec: dict = KubernetesSpec(**self.template_body["kubernetes"])
self.body.spec["volumes"] = k8s_spec.volumes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,27 @@ def get_pod_status(self, reason: str, message: str | None = None):
]
)

def test_get_body_initializes_metadata_when_missing(self, mock_launcher):
mock_launcher.template_body["spark"].pop("metadata", None)
body = mock_launcher.get_body()
assert isinstance(body["metadata"], dict)
assert body["metadata"]["name"] == mock_launcher.name
assert body["metadata"]["namespace"] == mock_launcher.namespace

def test_get_body_replaces_non_dict_metadata(self, mock_launcher):
mock_launcher.template_body["spark"]["metadata"] = "not-a-dict"
body = mock_launcher.get_body()
assert isinstance(body["metadata"], dict)
assert body["metadata"]["name"] == mock_launcher.name
assert body["metadata"]["namespace"] == mock_launcher.namespace

def test_get_body_preserves_existing_metadata_labels(self, mock_launcher):
mock_launcher.template_body["spark"]["metadata"] = {"labels": {"team": "data"}}
body = mock_launcher.get_body()
assert body["metadata"]["labels"]["team"] == "data"
assert body["metadata"]["name"] == mock_launcher.name
assert body["metadata"]["namespace"] == mock_launcher.namespace

@patch("airflow.providers.cncf.kubernetes.operators.custom_object_launcher.PodManager")
def test_start_spark_job_no_error(self, mock_pod_manager, mock_launcher):
mock_launcher.start_spark_job()
Expand Down
Loading