Skip to content

Conversation

@KatalKavya96
Copy link
Contributor

UI: Restore “Expand/Collapse all” on XComs page
closes: #56061

What’s changed

  • Added Expand all / Collapse all controls to the XComs page toolbar, matching the Audit Logs page.

  • Plumbed a boolean open state (via Chakra’s useDisclosure) into the XComs table and forwarded it to each row’s value renderer.

  • Updated XComEntry to accept an optional open prop and pass collapsed: !open to RenderedJsonField so JSON objects/arrays expand or collapse globally.

  • Kept scalar values rendering as plain text; added lightweight URL auto-linking for better readability.

Rationale

  • The Audit Logs page exposes a global expand/collapse control for JSON content, but XComs did not. This restores UI parity and improves usability when scanning large XCom payloads.

Implementation notes

  • No API or backend changes.

  • Reused existing i18n keys from Audit Logs for button labels (auditLog.actions.expandAllExtra, auditLog.actions.collapseAllExtra).

  • No changes to table sorting, pagination, or filters.

Demo Video

Screen.Recording.2025-09-25.at.3.52.47.AM.mov

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 24, 2025
@KatalKavya96
Copy link
Contributor Author

@RoyLee1224 Sure i will re apply all changes that are unrelated and removed. Thanks for the review

@bbovenzi bbovenzi added this to the Airflow 3.1.1 milestone Sep 29, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

@pierrejeambrun pierrejeambrun merged commit 9c96500 into apache:main Oct 1, 2025
57 checks passed
@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Oct 1, 2025
github-actions bot pushed a commit that referenced this pull request Oct 1, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
(cherry picked from commit 9c96500)

Co-authored-by: Kavya Katal <KAVYAKATAL09@GMAIL.COM>
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

pierrejeambrun pushed a commit that referenced this pull request Oct 1, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
(cherry picked from commit 9c96500)

Co-authored-by: Kavya Katal <KAVYAKATAL09@GMAIL.COM>
@KatalKavya96
Copy link
Contributor Author

Thanks a lot @bbovenzi , @pierrejeambrun , and @RoyLee1224 for reviewing and giving your time on this PR. Really appreciate the feedback and guidance that helped get this in smoothly.

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
* UI: Add Expand/Collapse all to XComs page

* Restored few changes

* Fixing lint issue

* Made suggested Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No expand/collapse option on the Xcoms page

4 participants