-
Notifications
You must be signed in to change notification settings - Fork 16.3k
UI: Add Expand/Collapse all to XComs page #56083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add Expand/Collapse all to XComs page #56083
Conversation
|
@RoyLee1224 Sure i will re apply all changes that are unrelated and removed. Thanks for the review |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes (cherry picked from commit 9c96500) Co-authored-by: Kavya Katal <KAVYAKATAL09@GMAIL.COM>
|
Thanks a lot @bbovenzi , @pierrejeambrun , and @RoyLee1224 for reviewing and giving your time on this PR. Really appreciate the feedback and guidance that helped get this in smoothly. |
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
UI: Restore “Expand/Collapse all” on XComs page
closes: #56061
What’s changed
Added Expand all / Collapse all controls to the XComs page toolbar, matching the Audit Logs page.
Plumbed a boolean open state (via Chakra’s useDisclosure) into the XComs table and forwarded it to each row’s value renderer.
Updated XComEntry to accept an optional open prop and pass collapsed: !open to RenderedJsonField so JSON objects/arrays expand or collapse globally.
Kept scalar values rendering as plain text; added lightweight URL auto-linking for better readability.
Rationale
Implementation notes
No API or backend changes.
Reused existing i18n keys from Audit Logs for button labels (auditLog.actions.expandAllExtra, auditLog.actions.collapseAllExtra).
No changes to table sorting, pagination, or filters.
Demo Video
Screen.Recording.2025-09-25.at.3.52.47.AM.mov