Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4775] Fix incorrect parameter order in GceHook #5613

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

turbaszek
Copy link
Member

Fixes incorrect parameter order in GceHook._wait_for_operation_to_complete
method and adds additional tests.

Make sure you have checked all steps below.

Jira

Description

  • Fixes incorrect parameter order in GceHook._wait_for_operation_to_complete
    method and adds additional tests.

Tests

  • My PR adds the following unit tests

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

Fixes incorrect parameter order in GceHook._wait_for_operation_to_complete
method and adds additional tests.
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@potiuk potiuk merged commit 3a6a77c into apache:master Jul 19, 2019
potiuk pushed a commit that referenced this pull request Jul 26, 2019
Fixes incorrect parameter order in GceHook._wait_for_operation_to_complete
method and adds additional tests.
@potiuk
Copy link
Member

potiuk commented Jul 26, 2019

I merged it ti 1.10.4 v1-10-test branch as well

potiuk pushed a commit that referenced this pull request Jul 26, 2019
Fixes incorrect parameter order in GceHook._wait_for_operation_to_complete
method and adds additional tests.
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Fixes incorrect parameter order in GceHook._wait_for_operation_to_complete
method and adds additional tests.
@potiuk potiuk added the provider:google Google (including GCP) related issues label Jul 30, 2019
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
Fixes incorrect parameter order in GceHook._wait_for_operation_to_complete
method and adds additional tests.
@turbaszek turbaszek deleted the fix-gce-hook branch September 19, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants