-
Notifications
You must be signed in to change notification settings - Fork 16.3k
HTTP Notifier implementation #56160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Notifier implementation #56160
Conversation
|
Notifiers needs to register in provider.yaml airflow/providers/amazon/provider.yaml Lines 908 to 911 in 696fd73
I guess we are missing verification that any new notifier has corresponded entry in the provider.yaml |
d0b2f2b to
e652106
Compare
|
Bad rebase, please ignore if you were pinged. |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! No problem being pinged.
As you have in the PR description an example, can you add this example to the codebase as well and a reference into docs so that people can find it? Will be useful for people to know other than taking a look to the source.
providers/http/src/airflow/providers/http/notifications/__init__.py
Outdated
Show resolved
Hide resolved
d8bf6e2 to
2aa61fd
Compare
52411f8 to
09d6f56
Compare
09d6f56 to
d6b8606
Compare
Implementation and unit test for HTTP Notifier. Here's the Dag I used to test that it works end-to-end
I add a connection within airflow using:
And spin up a local API server via python:
Then I run the above Dag, and on the CLI with the python API-server running I can see the contents of the POST request that is triggered when the Dag completes successfully.