-
Notifications
You must be signed in to change notification settings - Fork 16.3k
docs:improve plugin system documentation for clarity and completeness #56177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @pierrejeambrun @jscheffl @bbovenzi -> any comments?
|
Bump on reviews @pierrejeambrun @jscheffl @bbovenzi |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one fix needed as indicated by Brent, good for me! LGTM after the small adjustment...
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me (now - applied feedback from Brent)
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…completeness (#56177) * docs:improve plugin system documentation for clarity and completeness * Apply suggestion from @kaxil * Review feedback Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> --------- (cherry picked from commit e6e3370) Co-authored-by: Lohith M <152604836+Lohith625@users.noreply.github.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
…completeness (apache#56177) * docs:improve plugin system documentation for clarity and completeness * Apply suggestion from @kaxil * Review feedback Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> --------- (cherry picked from commit e6e3370) Co-authored-by: Lohith M <152604836+Lohith625@users.noreply.github.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Overview
This PR improves the plugin system documentation for Airflow by:
Motivation
With the plugin system enhancements released in Airflow 3.1, it is a good time to revisit and improve the documentation to help developers adopt the new features quickly.
Related Issues
Closes #55837
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.