Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Sep 29, 2025

The referenced issue has been fixed so lets try to see if the underlying issue is resolved.
cc @VladaZakharova @Crowiant

related #53182

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Sep 29, 2025
@VladaZakharova
Copy link
Contributor

VladaZakharova commented Sep 30, 2025

hi
I have a question, why we can't install other dependencies along with bumping the version of google-cloud-aiplatform as you suggested in PR? I understand the change to bump the version, but I still think we need ray as an extra dependency in here :)

@eladkal
Copy link
Contributor Author

eladkal commented Sep 30, 2025

I have a question, why we can't install other dependencies along with bumping the version of google-cloud-aiplatform as you suggested in PR? I understand the change to bump the version, but I still think we need ray as an extra dependency in here :)

We can. I followed the comment that asked to remove it once the linked issue is resolved.
The key question here is if google-cloud-bigquery-storage is direct dependency of Airflow or not. To my understanding it's not it is part of the upstream extra
https://github.com/googleapis/python-aiplatform/blob/main/setup.py#L63C1-L63C27
but they don't expose this extra specifically https://github.com/googleapis/python-aiplatform/blob/a67a795974294111d6ff19dd70948055ccb8ae33/setup.py#L309
to get this you must install all extras so I think this is upstream bug(?)

@VladaZakharova
Copy link
Contributor

I have a question, why we can't install other dependencies along with bumping the version of google-cloud-aiplatform as you suggested in PR? I understand the change to bump the version, but I still think we need ray as an extra dependency in here :)

We can. I followed the comment that asked to remove it once the linked issue is resolved. The key question here is if google-cloud-bigquery-storage is direct dependency of Airflow or not. To my understanding it's not it is part of the upstream extra https://github.com/googleapis/python-aiplatform/blob/main/setup.py#L63C1-L63C27 but they don't expose this extra specifically https://github.com/googleapis/python-aiplatform/blob/a67a795974294111d6ff19dd70948055ccb8ae33/setup.py#L309 to get this you must install all extras so I think this is upstream bug(?)

From my understanding the issue mentioned in the comment is not actually fixed, it was just closed. I think we can remove mentioning of this issue in the comment at all WDYT?

@eladkal
Copy link
Contributor Author

eladkal commented Oct 2, 2025

From my understanding the issue mentioned in the comment is not actually fixed, it was just closed. I think we can remove mentioning of this issue in the comment at all WDYT?

Then this is not clear to me. The issue was opened due to a problem integrating Airflow with upstream library which now you say was not resolved.
I'd appreciate if Google can sort this internally and let us know what is their recommended way to proceed.

@potiuk
Copy link
Member

potiuk commented Oct 3, 2025

I'd appreciate if Google can sort this internally and let us know what is their recommended way to proceed.

I think it's ckear the issye is not resolved. I commented in the issaue and asked to reopen (as @VladaZakharova did) - I don;t think we can do more ( besides duplicating the issue and opening it again if they do not reopen) - for now, I would just keep the comment and hope they will re-open.

@potiuk
Copy link
Member

potiuk commented Oct 3, 2025

I am afraid one Google team has nothing to do with the other team - the issue in the repo is as much internal as external communication, and I am afraid Vlada and Composer team have about the same impact on it as us - commenting there.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 18, 2025
@github-actions github-actions bot closed this Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants