-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Only import OL plugin listeners/hooks if OL is enabled #56266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
kacpermuda
approved these changes
Oct 1, 2025
Contributor
kacpermuda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have no influence on the listener
eladkal
approved these changes
Oct 1, 2025
mobuchowski
reviewed
Oct 1, 2025
Contributor
mobuchowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jedcunningham do you have more info what takes so much memory? Transitive imports?
Member
Author
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
8 tasks
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
…pache#56266) These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

These imports ultimately aren't cheap - it results in ~80mb of memory use, so lets skip it unless the plugin is enabled.