[v3-1-test] UI: Fix Grid for cleared runs when tasks were removed (#56085) #56297
+119
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
pierrejeambrun
approved these changes
Oct 3, 2025
bugraoz93
approved these changes
Oct 4, 2025
pierrejeambrun
force-pushed
the
backport-77fae41-v3-1-test
branch
from
37f1cc0 to
e2ebc42
Compare
potiuk
force-pushed
the
backport-77fae41-v3-1-test
branch
2 times, most recently
from
1f715ac to
19fd4ae
Compare
…6085) Ensure removed/historical tasks from selected runs are visible in Grid even if they no longer exist in the current DAG version. We now: - Include synthetic leaf nodes for task_ids present in TIs but missing from the serialized DAG in both grid/structure and grid/ti_summaries. - Aggregate TI states for these synthetic nodes Add tests covering structure and TI summaries for removed tasks. (cherry picked from commit 77fae41) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
pierrejeambrun
force-pushed
the
backport-77fae41-v3-1-test
branch
from
19fd4ae to
6eaddc4
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Rebasing, main and v3-1-test were fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
Add tests covering structure and TI summaries for removed tasks.
(cherry picked from commit 77fae41)
Co-authored-by: Ephraim Anierobi splendidzigy24@gmail.com