Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Oct 3, 2025

The #56208 has broken v3-1-test because it added requirements for providers, where (at least curerntly) uv workspace in v3-1-test uses provider's depedencies from local "providers" folder. We are planning to remove providers from v3-1-test branch but this is not yet done and bumping providers only in "airflow" requireements without bumping them in pyproject.toml caused conflicts when installing airflow from local sources in CI image.

bumping the versions in pyproject.toml should solve the problem until different mechanism is implemented in v3-* branches.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

The apache#56208 has broken v3-1-test because it added requirements for
providers, where (at least curerntly) uv workspace in v3-1-test
uses provider's depedencies from local "providers" folder. We are
planning to remove providers from v3-1-test branch but this is not
yet done and bumping providers only in "airflow" requireements
without bumping them in pyproject.toml caused conflicts when installing
airflow from local sources in CI image.

bumping the versions in pyproject.toml should solve the problem until
different mechanism is implemented in v3-* branches.
@potiuk
Copy link
Member Author

potiuk commented Oct 3, 2025

@eladkal @kaxil -> this should fix broken image build in v3-1-test - broken by #56208 - which introduced conflict in the workspace where local providers in v3-1-test were conflicting with those specified in required dependencies by airflow-core.

As explained #56251 (comment) - this is a new thing to limit providers to higher versions than they were at the moment of branch relase. the #56251 backport failed (but was merged regardless). In the future when we remove providers entirely from v3* branches (which will require a number of breeze and workspace definition changes, so it is not yet done) this might work differently - but if we want to increase the version of provider to something higher than it was at the moment of branching things off, either the provider changes need to be baclported or the version artifficially bumped in provider.yaml (and generated pyproject.toml) - which I just did.

Since the #56251 was merged - apparently a few backports were merged without running tests (and failing) which is generallly not a good idea I think. Probably it would be better to wait with merging the #56251. Right now it's likely there will be other failures merged from those merged PRs (hopefully not). Generally speaking - it would be great idea to make sure tha the v3-1-test branch is back green - after this one is merged.

@potiuk
Copy link
Member Author

potiuk commented Oct 3, 2025

Image is correctly built and not failing in this one - so I am merging it now -> but if there are any fixes that needs to be done to make it green - I am not likely to be able to implement it while on vacations @eladkal @kaxil.

@potiuk potiuk merged commit 12a75c0 into apache:v3-1-test Oct 3, 2025
30 checks passed
@potiuk potiuk deleted the fix-v3-1-test-workspace-dependencies branch October 3, 2025 02:22
@potiuk
Copy link
Member Author

potiuk commented Oct 3, 2025

The (potential) failures in this build will be visible here: https://github.com/apache/airflow/actions/runs/18210782954/job/51850747016 (and In #internal-airflow-ci-cid channel on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant