-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix AsyncToSync call in Google provider #56363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
115d479 to
02b593d
Compare
|
@potiuk |
|
@shahar1 Hi :) maybe you can check the PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@VladaZakharova just making sure, are we good with the definition of the min. version of gcloud-aio-bigquery?
Edit: It seems that we need to increase the min. version of gcloud-aio-bigquery to at least 7.1.0, when the location patch was released.
This change was made to remove using event_loop inside the code. Since in Airflow recently was added ability to support async_to_sync without using event_loop, there is no need now here in the bq hook to use this event_loop call at all. So the change was made here not because of the library update, but because in Airflow now it is possible to avoid creation of event_loop every time we need to create sync call. |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.