-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Use Task Display Name in Grid if existing #56393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Task Display Name in Grid if existing #56393
Conversation
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
114e6fb to
c664f9a
Compare
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for using task_display_name in ui. I think re-run static check could fix the red ci, thanks!
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker d43b468 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff (cherry picked from commit d43b468) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff (cherry picked from commit d43b468) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
* Use Task Display Name in Grid if existing * Consider short task ID w/o prefix if no display name * Add some tests with labels on tasks * Apply ruff
While I was prepping PR #56392 I noticed that the Task Display Name is not used (anymore?) in the Grid view. Might be a victim of refactoring... this PR adds the Task Display name back again such that "beautiful" task names as introduced in Airflow 2.10 are back again in Grid view.
Before:

After:
