-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Werkzeug Version Check #56398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Werkzeug Version Check #56398
Conversation
…hashing algorithms available to different versions of werkzeug
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Yep. Much better in the light of pallets/werkzeug#2770 |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @utieyin - since we are trying to keep up wth the original code https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/security/manager.py#L230C1-L245C14 - it's better to do it as @dpgaspar did in FAB security manager.
|
Could you please change it to importlib check as in the original code @utieyin ? |
Most certainly |
…nto werkzeug-version-patch
providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py
Show resolved
Hide resolved
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
Thanks! |
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug * Using Version check as done by the upstream FAB provider * Removing used var * Adding missing importlib import
Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug
Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug.
The current code checks the version of werkzeug and uses that to determine what hash to use. This breaks for werkzeug greater than 2.3.8 as seen here https://github.com/pallets/werkzeug/blob/504a8c4fbda9b8b2fd09e817544ffd228f23458e/CHANGES.rst#L182.
The proposed change uses feature detection to see if scrypt is available or not
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.