Skip to content

Conversation

@utieyin
Copy link
Contributor

@utieyin utieyin commented Oct 4, 2025

Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug.
The current code checks the version of werkzeug and uses that to determine what hash to use. This breaks for werkzeug greater than 2.3.8 as seen here https://github.com/pallets/werkzeug/blob/504a8c4fbda9b8b2fd09e817544ffd228f23458e/CHANGES.rst#L182.
The proposed change uses feature detection to see if scrypt is available or not


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

…hashing algorithms available to different versions of werkzeug
@utieyin utieyin requested a review from vincbeck as a code owner October 4, 2025 22:50
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 4, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Oct 5, 2025

Yep. Much better in the light of pallets/werkzeug#2770

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @utieyin - since we are trying to keep up wth the original code https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/security/manager.py#L230C1-L245C14 - it's better to do it as @dpgaspar did in FAB security manager.

@potiuk
Copy link
Member

potiuk commented Oct 5, 2025

Could you please change it to importlib check as in the original code @utieyin ?

@utieyin
Copy link
Contributor Author

utieyin commented Oct 5, 2025

Could you please change it to importlib check as in the original code @utieyin ?

Most certainly

@utieyin utieyin requested a review from potiuk October 5, 2025 14:06
@utieyin utieyin requested a review from potiuk October 6, 2025 07:20
@potiuk potiuk merged commit cc1a000 into apache:main Oct 6, 2025
76 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 6, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@vincbeck
Copy link
Contributor

vincbeck commented Oct 6, 2025

Thanks!

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
* Added feature detection in werkzeug fab providers to allow detecting hashing algorithms available to different versions of werkzeug

* Using Version check as done by the upstream FAB provider

* Removing used var

* Adding missing importlib import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants