fix: show appropriate time units in grid view #56403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyLee1224
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Contributor
|
Note before merging: Can you check whether the translation key "seconds" is used in anotherplace and prune it from all translations if this is the last usage? |
RoyLee1224
requested review from
BasPH,
Lee-W,
bugraoz93,
eladkal,
hussein-awala,
jason810496,
mobuchowski,
potiuk,
romsharon98,
shahar1,
vatsrahul1001 and
vincbeck
as code owners
Contributor
Author
1. Confirmed: The translation key
|
RoyLee1224
force-pushed
the
grid-duration
branch
from
d422f31 to
91bef25
Compare
jscheffl
approved these changes
Oct 5, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Good for me! Thanks for cleaning the translation.
jscheffl
added
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys (cherry picked from commit f10c905) Co-authored-by: LI,JHE-CHEN <103923510+RoyLee1224@users.noreply.github.com>
Backport successfully created: v3-1-test
|
jscheffl
pushed a commit
that referenced
this pull request
Oct 5, 2025
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
* fix: show appropriate time units in grid view * i18n: remove second translation keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
part of #56250
Why
Screenshots
Notes
We would need to remove all of the translation keys for "seconds"
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.