Skip to content

Add poke_mode_only to version_compat to fix the incorrect deprecation warning #56435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Oct 13, 2025
Merged

Add poke_mode_only to version_compat to fix the incorrect deprecation warning #56435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f7cf7a
fix the deprecation warning
zachliu Oct 6, 2025
7eeb07e
for pre-3.1 versions
zachliu Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/amazon/src/airflow/providers/amazon/aws/sensors/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
from airflow.providers.amazon.aws.sensors.base_aws import AwsBaseSensor
from airflow.providers.amazon.aws.triggers.s3 import S3KeysUnchangedTrigger, S3KeyTrigger
from airflow.providers.amazon.aws.utils.mixins import aws_template_fields
from airflow.sensors.base import poke_mode_only
from airflow.providers.amazon.version_compat import poke_mode_only


class S3KeySensor(AwsBaseSensor[S3Hook]):
Expand Down
3 changes: 3 additions & 0 deletions providers/amazon/src/airflow/providers/amazon/version_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:

if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import BaseHook
from airflow.sdk.bases.sensor import poke_mode_only
else:
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]
from airflow.sensors.base import poke_mode_only # type: ignore[no-redef]

if AIRFLOW_V_3_0_PLUS:
from airflow.sdk import BaseOperator, BaseOperatorLink, BaseSensorOperator
Expand All @@ -55,5 +57,6 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
"BaseOperator",
"BaseOperatorLink",
"BaseSensorOperator",
"poke_mode_only",
"XCom",
]
Loading