Render DAG tags alphabetically #56478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace non-null assertion with proper null check and array destructuring - Add explicit error handling for missing mock data - Add Jest DOM types import for TypeScript compatibility - Maintains test functionality while following linting rules
stuart23
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Contributor
|
I feel like we should add sorting to the API instead. |
Contributor
|
Something like this can be added in the API side that should sort tags by name. diff --git a/airflow-core/src/airflow/api_fastapi/core_api/datamodels/dags.py b/airflow-core/src/airflow/api_fastapi/core_api/datamodels/dags.py
index 23aa4ec300..3ff50fd2b5 100644
--- a/airflow-core/src/airflow/api_fastapi/core_api/datamodels/dags.py
+++ b/airflow-core/src/airflow/api_fastapi/core_api/datamodels/dags.py
@@ -29,6 +29,7 @@ from pydantic import (
ConfigDict,
computed_field,
field_validator,
+ field_serializer
)
from airflow.api_fastapi.core_api.base import BaseModel, StrictBaseModel
@@ -114,6 +115,9 @@ class DAGResponse(BaseModel):
}
return serializer.dumps(payload)
+ @field_serializer('tags')
+ def serialize_tags(tags: list[DagTagResponse]):
+ return sorted(tags, key=lambda tag: tag.name) |
Member
|
I aggree that this should be done at the API level. +1 for a field serializer. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Contributor
Author
|
Closed in favour of #58883 as per recommendations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tags on the DAGs card view are rendered in the order they are received from the API server which can be inconsistent and makes it difficult to compare DAGs with the same tag-set. This sorts the labels first before rendering them.
A test has been added as well to confirm the functionality.