-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add fail_on_file_not_exist to SFTPToGCSOperator #56528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 11 commits into
apache:main
from
nguy4130:fail_on_sftp_file_not_exist_gcs
Oct 19, 2025
Merged
Add fail_on_file_not_exist to SFTPToGCSOperator #56528
potiuk
merged 11 commits into
apache:main
from
nguy4130:fail_on_sftp_file_not_exist_gcs
Oct 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MaksYermak
approved these changes
Oct 14, 2025
potiuk
approved these changes
Oct 14, 2025
Member
|
Nice - but CI does not agree :) |
Member
|
Still :( |
Contributor
Author
|
@potiuk CI should be happy now! |
Member
🤞 |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Oct 20, 2025
* Add fail_on_file_not_exist to SFTPToGCSOperator * working with local DAG * working with local DAG * Trigger Build * fix test * fix unit test case --------- Co-authored-by: John Nguyen <john.nguyen@creditkarma.com>
69 tasks
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
* Add fail_on_file_not_exist to SFTPToGCSOperator * working with local DAG * working with local DAG * Trigger Build * fix test * fix unit test case --------- Co-authored-by: John Nguyen <john.nguyen@creditkarma.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #41472
Adding
fail_on_file_not_exist paramto SFTPToGCSOperator so that user can configure the parameter and operator will not fail in case of sftp file not exist.Note that this is only added to the non-wildcard source file path as that code already kind of handles when the file does not exist.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.Tested with a local DAG
when

fail_on_file_not_exist=False, the DAG exited gracefullywhen

fail_on_file_not_exist=Trueor not set, the DAG failed with error (existing behavior)