Skip to content

Fix openlineage dag state event emit on timed out dag #56542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mobuchowski merged 3 commits into from
Oct 10, 2025
Merged

Fix openlineage dag state event emit on timed out dag #56542

mobuchowski merged 3 commits into from
Oct 10, 2025

Conversation

@antonlin1
Copy link
Contributor

@antonlin1 antonlin1 commented Oct 10, 2025

For dag that is timed out, with only skipped tasks, following error is thrown

Failed to emit OpenLineage DAG failed event: 
 Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/airflow/providers/openlineage/plugins/adapter.py", line 505, in dag_failed
    **get_airflow_state_run_facet(dag_id, run_id, task_ids, dag_run_state),
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/airflow/providers/openlineage/utils/utils.py", line 746, in get_airflow_state_run_facet
    else (ti.end_date - ti.start_date).total_seconds()
          ~~~~~~~~~~~~^~~~~~~~~~~~~~~
TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType'

This PR fixes said issue

@antonlin1 antonlin1 force-pushed the antonlin/fix_ol_event_on_timeout branch from 243d853 to 489c75c Compare October 10, 2025 10:35
@antonlin1
Copy link
Contributor Author

antonlin1 commented Oct 10, 2025 •
edited
Loading

/merge lol this is not datadog

@mobuchowski mobuchowski merged commit 1951f9b into apache:main Oct 10, 2025
80 checks passed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
@antonlin1
Fix openlineage dag state event emit on timed out dag (apache#56542)
b9cb65d 
* fix openlineage dag state event emit on dag with skipped tasks

* fix tests

* rid of else
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
@antonlin1
Fix openlineage dag state event emit on timed out dag (apache#56542)
ab862f0 
* fix openlineage dag state event emit on dag with skipped tasks

* fix tests

* rid of else
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
@antonlin1 @dabla
Fix openlineage dag state event emit on timed out dag (apache#56542)
899a092 
* fix openlineage dag state event emit on dag with skipped tasks

* fix tests

* rid of else
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
@antonlin1
Fix openlineage dag state event emit on timed out dag (apache#56542)
6088e7a 
* fix openlineage dag state event emit on dag with skipped tasks

* fix tests

* rid of else
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
@antonlin1
Fix openlineage dag state event emit on timed out dag (apache#56542)
5317656 
* fix openlineage dag state event emit on dag with skipped tasks

* fix tests

* rid of else
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
@antonlin1
Fix openlineage dag state event emit on timed out dag (apache#56542)
7303f57 
* fix openlineage dag state event emit on dag with skipped tasks

* fix tests

* rid of else
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
@antonlin1
Fix openlineage dag state event emit on timed out dag (apache#56542)
d7eb724 
* fix openlineage dag state event emit on dag with skipped tasks

* fix tests

* rid of else
@eladkal eladkal mentioned this pull request Oct 22, 2025
Closed
69 tasks
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
@antonlin1 @TyrellHaywood
Fix openlineage dag state event emit on timed out dag (apache#56542)
01de4d8 
* fix openlineage dag state event emit on dag with skipped tasks

* fix tests

* rid of else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mobuchowski mobuchowski mobuchowski approved these changes

Assignees

No one assigned

Labels

area:providers provider:openlineage AIP-53

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonlin1 @mobuchowski