-
Notifications
You must be signed in to change notification settings - Fork 16.3k
FIX: Added missing babel dependency in Task SDK #56553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
huh Task SDK tests didn't run. Need to probably update the selective checks. |
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From your issue:
Use the
macros.ds_format_localein your jinja expressions and you will get an ModuleNotFoundError: No module named 'babel' error.
Could you create a unit test to reproduce the issue and ensure it's fixed by this change?
Normally there was an existing unit test for this before the move if I remember correctly, maybe I got removed? |
After the [move of macros to the Task SDK](https://github.com/apache/airflow/pull/46867/files#diff-854d19db18bae58289f4ce996ca0fb34341bc0f22930620627afccbd9d6facfcL30), the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again. (cherry picked from commit f96bb22) Co-authored-by: David Blain <info@dabla.be> closes: apache#56552
After the [move of macros to the Task SDK](https://github.com/apache/airflow/pull/46867/files#diff-854d19db18bae58289f4ce996ca0fb34341bc0f22930620627afccbd9d6facfcL30), the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again. (cherry picked from commit f96bb22) Co-authored-by: David Blain <info@dabla.be> closes: #56552
This reverts commit f96bb22.
After the [move of macros to the Task SDK](https://github.com/apache/airflow/pull/46867/files#diff-854d19db18bae58289f4ce996ca0fb34341bc0f22930620627afccbd9d6facfcL30), the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again. closes: apache#56552
After the [move of macros to the Task SDK](https://github.com/apache/airflow/pull/46867/files#diff-854d19db18bae58289f4ce996ca0fb34341bc0f22930620627afccbd9d6facfcL30), the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again. closes: apache#56552
After the [move of macros to the Task SDK](https://github.com/apache/airflow/pull/46867/files#diff-854d19db18bae58289f4ce996ca0fb34341bc0f22930620627afccbd9d6facfcL30), the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again. (cherry picked from commit f96bb22) closes: #56552 Co-authored-by: David Blain <info@dabla.be>
After the [move of macros to the Task SDK](https://github.com/apache/airflow/pull/46867/files#diff-854d19db18bae58289f4ce996ca0fb34341bc0f22930620627afccbd9d6facfcL30), the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again. closes: apache#56552
After the [move of macros to the Task SDK](https://github.com/apache/airflow/pull/46867/files#diff-854d19db18bae58289f4ce996ca0fb34341bc0f22930620627afccbd9d6facfcL30), the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again. closes: apache#56552
After the [move of macros to the Task SDK](https://github.com/apache/airflow/pull/46867/files#diff-854d19db18bae58289f4ce996ca0fb34341bc0f22930620627afccbd9d6facfcL30), the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again. closes: apache#56552
After the move of macros to the Task SDK, the babel dependency is missing. This is probably due to the fact that in the past, the babel dependency was available through the flask-babel dependency. This PR add the babel dependency to the Task SDK so that macro's depending on it can work again.
closes: #56552
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.