-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4316] support setting kubernetes_environment_variables config section from env var #5668
Conversation
6834d99
to
843cd90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update PR title and commit message to target AIRFLOW-4316 too
b49b53c
to
5505aad
Compare
1d74390
to
57ba24f
Compare
I decided to leave @ashb please let me know you think we should go the other route instead, i.e. make all environment variable case sensitive. |
…g section from env var When AIRFLOW_KUBERNETES_ENVIRONMENT_VARIABLES__AIRFLOW_HOME is set in the scheduler, AIRFLOW_HOME should be set for workers, not airflow_home.
…g section from env var (apache#5668) When AIRFLOW_KUBERNETES_ENVIRONMENT_VARIABLES__AIRFLOW_HOME is set in the scheduler, AIRFLOW_HOME should be set for workers, not airflow_home. (cherry picked from commit bffc0c9)
…g section from env var (apache#5668) When AIRFLOW_KUBERNETES_ENVIRONMENT_VARIABLES__AIRFLOW_HOME is set in the scheduler, AIRFLOW_HOME should be set for workers, not airflow_home.
Jira
Description
When
AIRFLOW_KUBERNETES_ENVIRONMENT_VARIABLES__AIRFLOW_HOME
is set inthe scheduler,
AIRFLOW_HOME
should be set for workers, not airflow_home. This meanskubernetes_environment_variables
section's keys need to be parsed with case sensitivity.Tests
Updated test in
test_env_var_config
to capture the requirement.Commits
Documentation
Code Quality
flake8