Make AwaitMessageTrigger inherit BaseEventTrigger
#56741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopidesupavan
approved these changes
Oct 16, 2025
potiuk
approved these changes
Oct 17, 2025
Member
|
Though there are import errors |
vincbeck
force-pushed
the
vincbeck/kafka_base_event
branch
from
2573021 to
2064d6e
Compare
vincbeck
force-pushed
the
vincbeck/kafka_base_event
branch
from
2064d6e to
42d0808
Compare
jason810496
approved these changes
Oct 17, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
I just saw the review on Azure Service Bus one. Thanks for the review and fixing the inheritance!
eladkal
approved these changes
Oct 17, 2025
Member
|
Likely rebase should fix the static check issue. |
vincbeck
force-pushed
the
vincbeck/kafka_base_event
branch
from
42d0808 to
bf3d7e9
Compare
Contributor
Author
Still failing. I think main is broken |
vincbeck
force-pushed
the
vincbeck/kafka_base_event
branch
from
bf3d7e9 to
c0545b9
Compare
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Oct 20, 2025
69 tasks
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trigger is compatible with event-driven scheduling, it should inherit
BaseEventTrigger. Without it, you cannot use it directly to schedule your Dags.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.