Merged
Conversation
boring-cyborg
bot
added
area:API
Member
Author
|
after some tesitng, I feel we might need to revert part of the #55952 implementation 🤔 (related to ti history) |
Lee-W
force-pushed
the
hitl-history-ui
branch
2 times, most recently
from
bb30a01 to
5a2dc8e
Compare
Lee-W
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
Lee-W
force-pushed
the
hitl-history-ui
branch
from
5a2dc8e to
91848f8
Compare
Lee-W
force-pushed
the
hitl-history-ui
branch
from
91848f8 to
3ed2c75
Compare
guan404ming
reviewed
Oct 28, 2025
Member
guan404ming
left a comment
guan404ming
left a comment
There was a problem hiding this comment.
Thanks for the PR, UI wise looks good.
I found a minor cache issue in my local test.
Screen.Recording.2025-10-29.at.12.39.54.AM.mov
We need to invalidate the cache when submitting a reply by adding:
[useTaskInstanceServiceGetHitlDetailTryKey, { dagId, dagRunId, mapIndex, taskId }],
to the mutation's onSuccess callback at
Feel free to let me know if anything's unclear or if you'd like me to explain further!
airflow-core/src/airflow/ui/src/pages/TaskInstance/HITLResponse.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
reviewed
Oct 30, 2025
airflow-core/src/airflow/api_fastapi/core_api/datamodels/hitl.py
Outdated
Show resolved
Hide resolved
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Maybe rebase this PR because the backend part was merged and typo was fixed, this will make the changelog limited to the front-end part and make it easier to review I believe.
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py
Outdated
Show resolved
Hide resolved
Member
Author
|
Mark it as a draft. I'll get back to it if bandwidth allow |
Lee-W
force-pushed
the
hitl-history-ui
branch
5 times, most recently
from
45f398c to
248367b
Compare
…te hitl_try endpoint instead
Lee-W
force-pushed
the
hitl-history-ui
branch
from
248367b to
c558d5a
Compare
bbovenzi
approved these changes
Jan 14, 2026
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
This is a good start. I want to make some other UX changes to improve HITL but thats separate from this functionality
github-project-automation
bot
moved this from In review
to Done
in AIP-90 - Human in the loop
Member
Author
|
Got it. Thanks @bbovenzi ! |
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
Jan 22, 2026
* feat(hitl): hitl history ui * fix(hitl): remove hitl from task_instance_history but create a separate hitl_try endpoint instead * feat(hitl): use HITLHistory in the frontend * feat(hitl): add auto refresh * fix: fix ci failure * fix(hitl): fix typo * refactor: rename local variable * refactor(hitl): remove -1 from try Number * fix(HITL): fix missing diabled in the UI
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
* feat(hitl): hitl history ui * fix(hitl): remove hitl from task_instance_history but create a separate hitl_try endpoint instead * feat(hitl): use HITLHistory in the frontend * feat(hitl): add auto refresh * fix: fix ci failure * fix(hitl): fix typo * refactor: rename local variable * refactor(hitl): remove -1 from try Number * fix(HITL): fix missing diabled in the UI
25 tasks
choo121600
pushed a commit
to choo121600/airflow
that referenced
this pull request
Feb 22, 2026
* feat(hitl): hitl history ui * fix(hitl): remove hitl from task_instance_history but create a separate hitl_try endpoint instead * feat(hitl): use HITLHistory in the frontend * feat(hitl): add auto refresh * fix: fix ci failure * fix(hitl): fix typo * refactor: rename local variable * refactor(hitl): remove -1 from try Number * fix(HITL): fix missing diabled in the UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The backend side of HITLHistory was added in #55952, but the UI part wasn't.
Closes: #54956
What
Screenshot
try 1
try 2
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.