[v3-1-test] Ensure dag.test uses serialized dag for testing (#56660) #56820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure dag.test uses serialized dag for testing While `dag test` command uses serialized dag, dag.test was using in-memory serialized dag making direct usage of dag.test method resulting in error. This PR fixes this and ensures dag.test parses dag if the dag is not parsed * fixup! Ensure dag.test uses serialized dag for testing * Update query to v2 and do backcompat for 3.1 * Remove backcompat * Return previous behaviour with SerializedDag (cherry picked from commit 6d977a9)
ephraimbuddy
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
Member
|
Something missing from being cherry-picked @ephraimbuddy ? |
ephraimbuddy
force-pushed
the
backport-56660
branch
from
d30d716 to
ff8f081
Compare
Contributor
Author
Yes, I thought sync_bag_to_db was not backported. Turns out it's backported but the import part has changed. Have fixed it |
potiuk
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.