Skip to content

Fix mypy type errors in Teradata provider for SQLAlchemy 2 upgrade #56861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 2 commits into from
Oct 20, 2025
+8 −12
Merged

Fix mypy type errors in Teradata provider for SQLAlchemy 2 upgrade #56861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9bd8e4
fix: Fix mypy type errors in Teradata provider for SQLAlchemy 2 upgrade
RoyLee1224 Oct 19, 2025
a417bca
fix: only include database when schema is not empty
RoyLee1224 Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions providers/teradata/src/airflow/providers/teradata/hooks/teradata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,18 +206,14 @@ def sqlalchemy_url(self) -> URL:
connection = self.get_connection(self.get_conn_id())
# Adding only teradatasqlalchemy supported connection parameters.
# https://pypi.org/project/teradatasqlalchemy/#ConnectionParameters
url_kwargs = {
"drivername": "teradatasql",
"username": connection.login,
"password": connection.password,
"host": connection.host,
"port": connection.port,
}

if connection.schema: # Only include database if it's not None or empty
url_kwargs["database"] = connection.schema

return URL.create(**url_kwargs)
return URL.create(
drivername="teradatasql",
username=connection.login,
password=connection.password,
host=connection.host,
port=connection.port,
database=connection.schema if connection.schema else None,
)

def get_uri(self) -> str:
"""Override DbApiHook get_uri method for get_sqlalchemy_engine()."""
Expand Down