Fix log text selection contrast in light mode (#56216) #56893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix log text selection contrast in light mode Changed selection background from brand.subtle to gray.emphasized to improve readability when highlighting text in the log viewer. This aligns with the DAG code viewer styling and provides better contrast across both light and dark themes. * Brent's suggestions (cherry picked from commit 8966d28)
pierrejeambrun
requested review from
bbovenzi,
jscheffl,
ryanahamilton and
shubhamraj-git
as code owners
This was referenced Oct 20, 2025
dheerajturaga
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix log text selection contrast in light mode
Changed selection background from brand.subtle to gray.emphasized to improve readability when highlighting text in the log viewer. This aligns with the DAG code viewer styling and provides better contrast across both light and dark themes.
Brent's suggestions
(cherry picked from commit 8966d28)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.