-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Handle invalid token in JWTRefreshMiddleware
#56904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The PR that broke it... did this go to v3-1-test and do we need to backport this? |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirmt his fixes it! Thanks for helping out (faster than I was able to make my hands dirty...)
No, |
(cherry picked from commit d0e6222)
Apparently that changed, backport PR #58649, so we need to backport this too. |
(cherry picked from commit d0e6222)
Very good catch! I can do it |
|
@vincbeck Ephraim is on it. (same for the other PR). As he is cutting rc2 |
Even better! Thanks for the heads-up |
(cherry picked from commit d0e6222)
(cherry picked from commit d0e6222)
When the token is invalid, the middleware
JWTRefreshMiddlewarecreates a 500. Handle this use case. An easy reproducible step is to not setAIRFLOW__API_AUTH__JWT_SECRET, and restarting breeze while keeping your browser open.See discussion in Slack.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.