Skip to content

Fix Git corruption recovery by moving fetch into retry context #56913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 2 commits into from
Oct 28, 2025
Merged

Fix Git corruption recovery by moving fetch into retry context #56913

potiuk merged 2 commits into from
Oct 28, 2025
+9 −3

Conversation

@dheerajturaga
Copy link
Member

@dheerajturaga dheerajturaga commented Oct 20, 2025 •
edited
Loading

Add _fetch_bare_repo into _clone_bare_repo_if_required
so that fetch failures (e.g., corrupted packs
with unresolved deltas) trigger the existing @Retry mechanism to clean up
and re-clone the bare repository automatically.

this resolves errors such as

[2025-10-20 12:31:58] ERROR - Top level error
GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git fetch -v -- origin +refs/heads/*:refs/heads/* +refs/tags/*:refs/tags/*
  stderr: 'error: refs/heads/temp/07694dfc89033d3d0da25f5344f30c371a380c6f does not point to a valid object!
error: refs/heads/temp/07694dfc89033d3d0da25f5344f30c371a380c6f does not point to a valid object!
error: Could not read d29a5e4f1afe9994c4e6daf9c84ccbec8abc459e
fatal: pack has 193 unresolved deltas
fatal: fetch-pack: invalid index-pack output'

cc: @ephraimbuddy

@dheerajturaga
Fix Git corruption recovery by moving fetch into retry context
8a10bc6 
  Move _fetch_bare_repo call from _ensure_version_in_bare_repo into
  _clone_bare_repo_if_required so that fetch failures (e.g., corrupted packs
  with unresolved deltas) trigger the existing @Retry mechanism to clean up
  and re-clone the bare repository automatically.
@eladkal eladkal requested a review from ephraimbuddy October 22, 2025 08:24
@potiuk
Copy link
Member

potiuk commented Oct 28, 2025

Nice!

@potiuk potiuk merged commit b32603f into apache:main Oct 28, 2025
112 checks passed
@potiuk potiuk mentioned this pull request Nov 14, 2025
Closed
@jscheffl jscheffl mentioned this pull request Nov 27, 2025
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

Assignees

No one assigned

Labels

area:providers provider:git

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dheerajturaga @potiuk