Skip to content

Migrate postgres provider to common.compat #57022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jason810496 merged 3 commits into from
Oct 22, 2025
Merged

Migrate postgres provider to common.compat #57022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cfed3e
Migrate postgres provider to ``common.compat``
kaxil Oct 22, 2025
18ebdde
attempting to fix tests
amoghrajesh Oct 22, 2025
b527272
attempting to fix tests
amoghrajesh Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/breeze/tests/test_selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
"providers/postgres/tests/unit/postgres/file.py",
),
{
"selected-providers-list-as-string": "amazon common.sql google "
"selected-providers-list-as-string": "amazon common.compat common.sql google "
"microsoft.azure openlineage pgvector postgres",
"all-python-versions": f"['{DEFAULT_PYTHON_MAJOR_MINOR_VERSION}']",
"all-python-versions-list-as-string": DEFAULT_PYTHON_MAJOR_MINOR_VERSION,
Expand All @@ -650,7 +650,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
{
"description": "amazon...google",
"test_types": "Providers[amazon] "
"Providers[common.sql,microsoft.azure,openlineage,pgvector,postgres] "
"Providers[common.compat,common.sql,microsoft.azure,openlineage,pgvector,postgres] "
"Providers[google]",
}
]
Expand Down
2 changes: 2 additions & 0 deletions providers/postgres/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ requires-python = ">=3.10"
# After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-common-compat>=1.7.4", # + TODO: bump to next version
"apache-airflow-providers-common-sql>=1.23.0",
"psycopg2-binary>=2.9.9; python_version < '3.13'",
"psycopg2-binary>=2.9.10; python_version >= '3.13'",
Expand Down Expand Up @@ -93,6 +94,7 @@ dev = [
"apache-airflow-task-sdk",
"apache-airflow-devel-common",
"apache-airflow-providers-amazon",
"apache-airflow-providers-common-compat",
"apache-airflow-providers-common-sql",
"apache-airflow-providers-microsoft-azure",
"apache-airflow-providers-openlineage",
Expand Down
6 changes: 1 addition & 5 deletions providers/postgres/src/airflow/providers/postgres/hooks/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,10 @@
AirflowException,
AirflowOptionalProviderFeatureException,
)
from airflow.providers.common.compat.sdk import Connection
from airflow.providers.common.sql.hooks.sql import DbApiHook
from airflow.providers.postgres.dialects.postgres import PostgresDialect

try:
from airflow.sdk import Connection
except ImportError:
from airflow.models.connection import Connection # type: ignore[assignment]

USE_PSYCOPG3: bool
try:
import psycopg as psycopg # needed for patching in unit tests
Expand Down
Loading