Skip to content

Fix dag list cache invalidation on favouriting a dag #57039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vatsrahul1001 merged 2 commits into from
Oct 22, 2025
Merged

Fix dag list cache invalidation on favouriting a dag #57039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a80fc
Fix dags list not rendering
pierrejeambrun Oct 22, 2025
b947240
Fix cache invalidation for dags list when favouriting a dag
pierrejeambrun Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airflow-core/src/airflow/ui/src/pages/DagsList/DagsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ const createColumns = (
header: "",
},
{
accessorKey: "favourite",
cell: ({ row: { original } }) => (
<FavoriteDagButton dagId={original.dag_id} isFavorite={original.is_favorite} withText={false} />
),
Expand Down
11 changes: 7 additions & 4 deletions airflow-core/src/airflow/ui/src/queries/useToggleFavoriteDag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,13 @@ export const useToggleFavoriteDag = (dagId: string) => {
queryKey: [useDagServiceGetDagsUiKey, UseDagServiceGetDagDetailsKeyFn({ dagId }, [{ dagId }])],
});

// Invalidate the specific DAG details query for this DAG
await queryClient.invalidateQueries({
queryKey: UseDagServiceGetDagDetailsKeyFn({ dagId }, [{ dagId }]),
});
const queryKeys = [
// Invalidate the specific DAG details query for this DAG and DAGs list query.
UseDagServiceGetDagDetailsKeyFn({ dagId }, [{ dagId }]),
[useDagServiceGetDagsUiKey],
];

await Promise.all(queryKeys.map((key) => queryClient.invalidateQueries({ queryKey: key })));
}, [queryClient, dagId]);

const favoriteMutation = useDagServiceFavoriteDag({
Expand Down