Skip to content

Migrate remaining providers to common.compat compatibility layer in celery #57067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rich7420 wants to merge 10 commits into from
Closed

Migrate remaining providers to common.compat compatibility layer in celery #57067

rich7420 wants to merge 10 commits into from

Conversation

@rich7420
Copy link
Contributor

@rich7420 rich7420 commented Oct 22, 2025

Replace version-specific conditional imports with common.compat layer. This standardizes compatibility handling across Airflow 2.x and 3.x.

This PR is a part of 57018 about provider celery.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

bugraoz93
bugraoz93 reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Could you please check the CI, the static checks failing. The Airflow CTL integration tests are fixed in main, rebase should fix that

@rich7420
Copy link
Contributor Author

rich7420 commented Oct 22, 2025

Looks good overall! Could you please check the CI, the static checks failing. The Airflow CTL integration tests are fixed in main, rebase should fix that

OK! thanks for your feedback!

@rich7420 rich7420 force-pushed the AIRFLOW57018-celery branch from 392ebb8 to 615a003 Compare October 22, 2025 15:56
eladkal
eladkal reviewed Oct 22, 2025
View reviewed changes
providers/celery/pyproject.toml Outdated
Comment on lines 72 to 74
"common.compat" = [
"apache-airflow-providers-common-compat>=1.7.4", # + TODO: bump to next version
]
Copy link
Contributor

@eladkal eladkal Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why as optional dependency?

Copy link
Contributor Author

@rich7420 rich7420 Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right , my mistake.

@rich7420 rich7420 requested a review from vincbeck as a code owner October 22, 2025 17:19
amoghrajesh
amoghrajesh reviewed Oct 23, 2025
View reviewed changes
providers/celery/pyproject.toml Outdated
Comment on lines 72 to 74
"common.compat" = [
"apache-airflow-providers-common-compat>=1.7.4", # + TODO: bump to next version
]
Copy link
Contributor

@amoghrajesh amoghrajesh Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to go to "dependencies"?

Copy link
Contributor Author

@rich7420 rich7420 Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amoghrajesh Yes! You're right. Thanks for your feedback!

@rawwar rawwar mentioned this pull request Oct 23, 2025
Closed
13 tasks
kaxil
kaxil reviewed Oct 23, 2025
View reviewed changes
@kaxil
Copy link
Member

kaxil commented Oct 23, 2025

Static check failure

@rich7420
Copy link
Contributor Author

rich7420 commented Oct 23, 2025

Static check failure

OK! I'll try to resolve it. But actually I don't why that test failed.
I'll try to figure out.

Update providers build files.....................................................Failed
- hook id: update-providers-build-files
- files were modified by this hook

rich7420 and others added 6 commits October 24, 2025 22:00
@rich7420 @kaxil
Migrate remaining providers to common.compat compatibility layer
0c075ab
@rich7420 @kaxil
Add TODO for version bump in optional dependencies
2d0d62e 
Added a TODO comment to indicate the need to bump the version of 'apache-airflow-providers-common-compat'.
@rich7420 @kaxil
fix ci test error
c572bea
@rich7420 @kaxil
Fix ruff linting error: move timeout import to top of file
45c32a7 
- Move 'from airflow.providers.common.compat.sdk import timeout' to top of file
- Fixes E402 Module level import not at top of file error
@rich7420 @kaxil
fix static check error
71386fa
@rich7420 @kaxil
add hash
c682a92
@kaxil kaxil force-pushed the AIRFLOW57018-celery branch from 05304a2 to 5a3298f Compare October 24, 2025 21:00
@kaxil kaxil mentioned this pull request Oct 27, 2025
Merged
@rich7420 rich7420 closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaxil kaxil kaxil left review comments

@bugraoz93 bugraoz93 bugraoz93 left review comments

@amoghrajesh amoghrajesh amoghrajesh left review comments

@eladkal eladkal eladkal left review comments

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@vincbeck vincbeck Awaiting requested review from vincbeck vincbeck is a code owner

Assignees

No one assigned

Labels

area:providers provider:celery

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rich7420 @kaxil @bugraoz93 @amoghrajesh @eladkal