Skip to content

Migrate samba provider to common.compat #57082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 4 commits into from
Oct 23, 2025
Merged

Migrate samba provider to common.compat #57082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05f04af
Migrate remaining providers to common.compat compatibility layer
rich7420 Oct 22, 2025
778baf0
modify error
rich7420 Oct 22, 2025
8f7d8ce
fix ruff error
rich7420 Oct 22, 2025
b9e32f2
Apply suggestion from @kaxil
kaxil Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions providers/samba/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ requires-python = ">=3.10"
# After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
dependencies = [
"apache-airflow>=2.10.0",
"apache-airflow-providers-common-compat>=1.8.0",
"smbprotocol>=1.5.0",
]

Expand All @@ -73,6 +74,7 @@ dev = [
"apache-airflow",
"apache-airflow-task-sdk",
"apache-airflow-devel-common",
"apache-airflow-providers-common-compat",
"apache-airflow-providers-google",
# Additional devel dependencies (do not remove this line and add extra development dependencies)
]
Expand Down
2 changes: 1 addition & 1 deletion providers/samba/src/airflow/providers/samba/hooks/samba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

import smbclient

from airflow.providers.samba.version_compat import BaseHook
from airflow.providers.common.compat.sdk import BaseHook

if TYPE_CHECKING:
import smbprotocol.connection
Expand Down
4 changes: 2 additions & 2 deletions providers/samba/src/airflow/providers/samba/transfers/gcs_to_samba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@
from typing import TYPE_CHECKING

from airflow.exceptions import AirflowException
from airflow.providers.common.compat.sdk import BaseOperator
from airflow.providers.google.cloud.hooks.gcs import GCSHook
from airflow.providers.samba.hooks.samba import SambaHook
from airflow.providers.samba.version_compat import BaseOperator

WILDCARD = "*"

if TYPE_CHECKING:
from airflow.providers.samba.version_compat import Context
from airflow.providers.common.compat.sdk import Context


class GCSToSambaOperator(BaseOperator):
Expand Down
17 changes: 4 additions & 13 deletions providers/samba/src/airflow/providers/samba/version_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,7 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0)
AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0)

if AIRFLOW_V_3_0_PLUS:
from airflow.sdk import BaseOperator
from airflow.sdk.definitions.context import Context
else:
from airflow.models import BaseOperator
from airflow.utils.context import Context

if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import BaseHook
else:
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]

__all__ = ["AIRFLOW_V_3_0_PLUS", "BaseHook", "BaseOperator", "Context"]
__all__ = [
"AIRFLOW_V_3_0_PLUS",
"AIRFLOW_V_3_1_PLUS",
]