Skip to content

Conversation

@vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Oct 22, 2025

Add team_id to public variable APIs. When a user create a variable through the public API, they need to specify the team (if any) it belongs to.

On task SDK/execution API side, the team should not be provided by the user (dag author in this context) but it should be inferred from the Dag. This change will be done in a separate PR. In this same future PR I'll also add authorization so that a variable that belongs to teamA cannot be retrieved from a Dag that belongs to teamB.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@vincbeck vincbeck requested review from o-nikolas and potiuk October 22, 2025 20:37
@boring-cyborg boring-cyborg bot added area:airflow-ctl area:API Airflow's REST/HTTP API area:DAG-processing area:task-sdk area:UI Related to UI/UX. For Frontend Developers. labels Oct 22, 2025
@vincbeck vincbeck force-pushed the vincbeck/variable_api_team branch 2 times, most recently from b49a16c to a41aae7 Compare October 23, 2025 15:55
@vincbeck vincbeck force-pushed the vincbeck/variable_api_team branch from a41aae7 to 7a65964 Compare October 30, 2025 16:31
@vincbeck vincbeck force-pushed the vincbeck/variable_api_team branch 5 times, most recently from ae1b9bd to ef0b2dd Compare November 7, 2025 18:06
@vincbeck vincbeck marked this pull request as ready for review November 7, 2025 18:06
@vincbeck vincbeck force-pushed the vincbeck/variable_api_team branch from ef0b2dd to fc4edc9 Compare November 7, 2025 19:13
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM overall.

@bbovenzi bbovenzi removed the area:UI Related to UI/UX. For Frontend Developers. label Nov 20, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside the comment above

@vincbeck vincbeck force-pushed the vincbeck/variable_api_team branch from fc4edc9 to de054a4 Compare November 24, 2025 16:15
@vincbeck vincbeck force-pushed the vincbeck/variable_api_team branch from de054a4 to f5e7fe9 Compare November 24, 2025 16:17
@vincbeck vincbeck merged commit d53814c into apache:main Nov 24, 2025
118 checks passed
@vincbeck vincbeck deleted the vincbeck/variable_api_team branch November 24, 2025 17:59
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants