-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add team_id to variable APIs
#57102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add team_id to variable APIs
#57102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b49a16c to
a41aae7
Compare
a41aae7 to
7a65964
Compare
ae1b9bd to
ef0b2dd
Compare
ef0b2dd to
fc4edc9
Compare
jason810496
approved these changes
Nov 8, 2025
Member
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM overall.
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_variables.py
Outdated
Show resolved
Hide resolved
bugraoz93
approved these changes
Nov 9, 2025
pierrejeambrun
approved these changes
Nov 21, 2025
Member
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside the comment above
fc4edc9 to
de054a4
Compare
de054a4 to
f5e7fe9
Compare
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
team_idto public variable APIs. When a user create a variable through the public API, they need to specify the team (if any) it belongs to.On task SDK/execution API side, the team should not be provided by the user (dag author in this context) but it should be inferred from the Dag. This change will be done in a separate PR. In this same future PR I'll also add authorization so that a variable that belongs to
teamAcannot be retrieved from a Dag that belongs toteamB.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.