Skip to content

Migrate Pagerduty provider to common.compat #57120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Oct 23, 2025
Merged

Migrate Pagerduty provider to common.compat #57120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/pagerduty/src/airflow/providers/pagerduty/hooks/pagerduty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import pagerduty

from airflow.exceptions import AirflowException
from airflow.providers.pagerduty.version_compat import BaseHook
from airflow.providers.common.compat.sdk import BaseHook


class PagerdutyHook(BaseHook):
Expand Down
2 changes: 1 addition & 1 deletion providers/pagerduty/src/airflow/providers/pagerduty/hooks/pagerduty_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
from asgiref.sync import sync_to_async

from airflow.exceptions import AirflowException
from airflow.providers.common.compat.sdk import BaseHook
from airflow.providers.http.hooks.http import HttpAsyncHook
from airflow.providers.pagerduty.version_compat import BaseHook

if TYPE_CHECKING:
from datetime import datetime
Expand Down
6 changes: 0 additions & 6 deletions providers/pagerduty/src/airflow/providers/pagerduty/version_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,7 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0)
AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0)

if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import BaseHook
else:
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]

__all__ = [
"AIRFLOW_V_3_0_PLUS",
"AIRFLOW_V_3_1_PLUS",
"BaseHook",
]