Skip to content

Conversation

@bhavaniravi
Copy link
Contributor

@bhavaniravi bhavaniravi commented Oct 23, 2025

part of: #57018


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Oct 23, 2025
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhavaniravi could you update the PR desc to have "part of issue-xyz" instead of "fixes issue-xyz"?

@bhavaniravi bhavaniravi force-pushed the bhavaniravi/migrate-google-to-common-compat branch 2 times, most recently from 3b132dd to 518f04e Compare October 23, 2025 08:22
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the BaseOperator from version_compat:

# Version-compatible imports
# BaseOperator: Use 3.1+ due to xcom_push method missing in SDK BaseOperator 3.0.x
# This is needed for DecoratedOperator compatibility
if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import (
BaseHook,
BaseOperator,
)
else:
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]
from airflow.models import BaseOperator

@bhavaniravi bhavaniravi force-pushed the bhavaniravi/migrate-google-to-common-compat branch from 518f04e to c9b1aee Compare October 24, 2025 04:23
@bhavaniravi bhavaniravi requested a review from kaxil October 24, 2025 05:35
@kaxil kaxil merged commit 5f6a2ab into apache:main Oct 24, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants