-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[Doc] Fixing some typos and spelling errors #57225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, another one. Thanks for the fixes!
|
Small fixes are needed to make CI green to make it merged:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
It seems we need to add chatbots word to docs/spelling_wordlist.txt to resolve the static check error. Thanks!
gopidesupavan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
|
LGTM! |
|
But some fixes are needed! |
|
Hi, |
It seems we need to add chatbots word to |
|
Added 'chatbots' and 'Chatbots' with capical C in case the word starts a sentence |
|
Okay, now as comment above it is "only" failing on changed breeze command outputs which are generated in code. To fix this run |
|
Ok, removed 'Chatbots' with capital C as it is not needed for now |
|
@jscheffl : Jens, I run the prek command that you requested. It has generated new versions for some file that I will commit now. Its output is: It has generated new versions for some file that I will commit now. |
uranusjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
|
Thanks for the fixes - CI is failing now... I see from logs it is un-related to your PR. Will attempt another run and hoping to have it green then. No need to fix from your side... |
* Fixing some typos and spelling errors * adding 'chatbot' to spelling_wordlist.txt * adding 'chatbots' to spelling_wordlist.txt * removed 'Chatbots' from spelling_wordlist.txt * Committing new versions of somes files generated by prek (cherry picked from commit a04136f) Co-authored-by: Didier Durand <2927957+didier-durand@users.noreply.github.com>
* Fixing some typos and spelling errors * adding 'chatbot' to spelling_wordlist.txt * adding 'chatbots' to spelling_wordlist.txt * removed 'Chatbots' from spelling_wordlist.txt * Committing new versions of somes files generated by prek (cherry picked from commit a04136f) Co-authored-by: Didier Durand <2927957+didier-durand@users.noreply.github.com>
) * Fixing some typos and spelling errors * adding 'chatbot' to spelling_wordlist.txt * adding 'chatbots' to spelling_wordlist.txt * removed 'Chatbots' from spelling_wordlist.txt * Committing new versions of somes files generated by prek (cherry picked from commit a04136f) Co-authored-by: Didier Durand <2927957+didier-durand@users.noreply.github.com>
* Fixing some typos and spelling errors * adding 'chatbot' to spelling_wordlist.txt * adding 'chatbots' to spelling_wordlist.txt * removed 'Chatbots' from spelling_wordlist.txt * Committing new versions of somes files generated by prek
* Fixing some typos and spelling errors * adding 'chatbot' to spelling_wordlist.txt * adding 'chatbots' to spelling_wordlist.txt * removed 'Chatbots' from spelling_wordlist.txt * Committing new versions of somes files generated by prek
Hi,
Discovered and fixed some typos while reading the code: see commit diffs for details
Best,
Didier