Skip to content

Fixes inconsistency with hook_params for sensor #57242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Oct 25, 2025
Merged

Fixes inconsistency with hook_params for sensor #57242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions providers/dbt/cloud/src/airflow/providers/dbt/cloud/sensors/dbt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def __init__(
run_id: int,
account_id: int | None = None,
deferrable: bool = conf.getboolean("operators", "default_deferrable", fallback=False),
hook_params: dict[str, Any] | None = None,
**kwargs,
) -> None:
if deferrable:
Expand All @@ -68,13 +69,13 @@ def __init__(
self.dbt_cloud_conn_id = dbt_cloud_conn_id
self.run_id = run_id
self.account_id = account_id

self.hook_params = hook_params or {}
self.deferrable = deferrable

@cached_property
def hook(self):
"""Returns DBT Cloud hook."""
return DbtCloudHook(self.dbt_cloud_conn_id)
return DbtCloudHook(self.dbt_cloud_conn_id, **self.hook_params)

def poke(self, context: Context) -> bool:
job_run_status = self.hook.get_job_run_status(run_id=self.run_id, account_id=self.account_id)
Expand Down Expand Up @@ -110,6 +111,7 @@ def execute(self, context: Context) -> None:
account_id=self.account_id,
poll_interval=self.poke_interval,
end_time=end_time,
hook_params=self.hook_params,
),
method_name="execute_complete",
)
Expand Down
2 changes: 2 additions & 0 deletions providers/dbt/cloud/tests/unit/dbt/cloud/sensors/test_dbt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,15 @@ def setup_class(self):
account_id=ACCOUNT_ID,
timeout=30,
poke_interval=15,
hook_params={"retry_limit": 3, "retry_delay": 2.0},
)

def test_init(self):
assert self.sensor.dbt_cloud_conn_id == "dbt"
assert self.sensor.run_id == RUN_ID
assert self.sensor.timeout == 30
assert self.sensor.poke_interval == 15
assert self.sensor.hook_params == {"retry_limit": 3, "retry_delay": 2.0}

@pytest.mark.parametrize(
argnames=("job_run_status", "expected_poke_result"),
Expand Down