Fix asset name overlap in DAG list (#56669) #57267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `truncate` with `isTruncated` in AssetSchedule.tsx to prevent long asset names from overlapping the latest run field.
if-i
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Author
|
Chakra UI – Text > Truncate text: https://v1.chakra-ui.com/docs/components/typography/text#truncate-text |
KoviAnusha
reviewed
Oct 25, 2025
Comment on lines
65
to
67
| <FiDatabase style={{ display: "inline" }} /> | ||
| <Link asChild color="fg.info" display="block" fontSize="sm" maxWidth="200px" truncate> | ||
| <Link asChild color="fg.info" display="block" fontSize="sm" maxWidth="200px" isTruncated> | ||
| <RouterLink to={`/assets/${asset.id}`}>{asset.name ?? asset.uri}</RouterLink> |
Contributor
There was a problem hiding this comment.
Good catch switching to isTruncated. You can also do a quick check if the tooltip/title still behaves as expected for long names.
Member
There was a problem hiding this comment.
Closing in favor of #57108 which is simpler, was opened earlier and is closer to be in a ready state (CI is green, code looks good)
Feel free to re-open if I missed something or if this PR adds something more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UI bug where long asset names overlap the latest run field by replacing
truncatewithisTruncatedinAssetSchedule.tsx. This ensures asset names are truncated properly and do not overlap.closes: #56669