Improve clarity on api workers recommendation in docs #57273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
|
LGTM |
ashb
reviewed
Oct 27, 2025
ashb
changed the title
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
pierrejeambrun
approved these changes
Oct 27, 2025
Contributor
Author
|
@ashb got your nit in & lint is passing. I'd merge except I don't have perms. So whenever anybody has a moment please press the green button thanks. |
potiuk
approved these changes
Oct 28, 2025
potiuk
added
the
backport-to-v3-1-test
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Oct 28, 2025
…ache#57273) --------- (cherry picked from commit 5cd27a0) Co-authored-by: r-richmond <rrichmond.gh@gmail.com> Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
potiuk
added a commit
that referenced
this pull request
Oct 28, 2025
Member
|
Backport: #57404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves documentation on API_WORKERS to help future users avoid the issues discovered in #52270.
#55707 was originally submitted by @jedcunningham to address this issue but the language therein does not adequately deter nor explain why one should avoid increasing the api workers.
This PR does 2 things. First it modifies to the docs to more strongly advocate for avoiding increasing the workers and secondly, and imo more importantly, it cites the issue for why this recommendation is in place.
Note: This config change helped us mitigate #56635 but I do not believe it is the root cause of that issue.