Better highlighting of selected task instance and edges in grid view #57275
Conversation
selected tasks and their connections. This change adds a blue glow effect and color highlighting to make selected elements stand out clearly.
dheerajturaga
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Cool!
As I am not a CSS Expert, letting some other expert another pair of eyes, else LGTM!
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Looks really nice, but I'd prefer is someone with better CSS knowledge than me could look more carefully
|
I get the need to make it more obvious what is selected. I don't know if I agree with the drop shadow effect. Let's just change the border color and width. |
Any reason for "don't know if agree"? Just layout nit, tooo fancy? Or any technical reason? |
Colorful drop shadows just aren't part of our design language, so I would prefer to stay consistent and not add it one-off. Also, I think the border state color and the drop shadow color are clashing. Perhaps we just override the border color when a task is selected? No information is lost since the state badge is always visible on the task node. |
… task is selected
Done! 
|
pierrejeambrun
added
the
backport-to-v3-1-test
…n grid view (#57275) * The previous bold border didn't provide enough visual distinction for selected tasks and their connections. This change adds a blue glow effect and color highlighting to make selected elements stand out clearly. * Brett's suggestions, remove box shadow and override border color when task is selected (cherry picked from commit 9111175) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
Backport successfully created: v3-1-test
|
…n grid view (#57275) (#57560) * The previous bold border didn't provide enough visual distinction for selected tasks and their connections. This change adds a blue glow effect and color highlighting to make selected elements stand out clearly. * Brett's suggestions, remove box shadow and override border color when task is selected (cherry picked from commit 9111175) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…pache#57275) * The previous bold border didn't provide enough visual distinction for selected tasks and their connections. This change adds a blue glow effect and color highlighting to make selected elements stand out clearly. * Brett's suggestions, remove box shadow and override border color when task is selected
6 participants
The previous bold border didn't provide enough visual distinction for
selected tasks and their connections. This change adds a blue glow effect
and color highlighting to make selected elements stand out clearly.
Grid.View.Glow.mp4